Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-28 06:29:29 +01:00
Code Packages Releases Activity

refactor(TestPodAntiAffinity): deduplicate setting Labels for foo-bar

Browse Source
This commit is contained in:
Jan Chaloupka
2025-12-15 13:37:55 +01:00
parent 6a00214457
commit 90672630da
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity_test.go
View File

@@ -71,6 +71,10 @@ func setPodAntiAffinityFoo1Bar1(pod *v1.Pod) {
test.SetPodAntiAffinity(pod, "foo1", "bar1") test.SetPodAntiAffinity(pod, "foo1", "bar1")
} }
func setLabelsFooBar(pod *v1.Pod) {
pod.Labels = map[string]string{"foo": "bar"}
}
func TestPodAntiAffinity(t *testing.T) { func TestPodAntiAffinity(t *testing.T) {
p1 := buildTestPodForNode1("p1", func(pod *v1.Pod) { p1 := buildTestPodForNode1("p1", func(pod *v1.Pod) {
@@ -79,7 +83,7 @@ func TestPodAntiAffinity(t *testing.T) {
}) })
p2 := buildTestPodForNode1("p2", func(pod *v1.Pod) { p2 := buildTestPodForNode1("p2", func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Labels = map[string]string{"foo": "bar"} setLabelsFooBar(pod)
}) })
p3 := buildTestPodForNode1("p3", func(pod *v1.Pod) { p3 := buildTestPodForNode1("p3", func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
@@ -91,13 +95,13 @@ func TestPodAntiAffinity(t *testing.T) {
}) })
p5 := buildTestPodForNode1("p5", func(pod *v1.Pod) { p5 := buildTestPodForNode1("p5", func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Labels = map[string]string{"foo": "bar"} setLabelsFooBar(pod)
setPodAntiAffinityFoo1Bar1(pod) setPodAntiAffinityFoo1Bar1(pod)
test.SetPodPriority(pod, 100) test.SetPodPriority(pod, 100)
}) })
p6 := buildTestPodForNode1("p6", func(pod *v1.Pod) { p6 := buildTestPodForNode1("p6", func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Labels = map[string]string{"foo": "bar"} setLabelsFooBar(pod)
setPodAntiAffinityFoo1Bar1(pod) setPodAntiAffinityFoo1Bar1(pod)
test.SetPodPriority(pod, 50) test.SetPodPriority(pod, 50)
}) })
@@ -124,13 +128,13 @@ func TestPodAntiAffinity(t *testing.T) {
}) })
p11 := buildTestPod("p11", nodeName5, func(pod *v1.Pod) { p11 := buildTestPod("p11", nodeName5, func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Labels = map[string]string{"foo": "bar"} setLabelsFooBar(pod)
}) })
nonEvictablePod := buildTestPodForNode1("non-evict", func(pod *v1.Pod) { nonEvictablePod := buildTestPodForNode1("non-evict", func(pod *v1.Pod) {
criticalPriority := utils.SystemCriticalPriority criticalPriority := utils.SystemCriticalPriority
pod.Spec.Priority = &criticalPriority pod.Spec.Priority = &criticalPriority
pod.Labels = map[string]string{"foo": "bar"} setLabelsFooBar(pod)
}) })
var uint1 uint = 1 var uint1 uint = 1