Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-28 06:29:29 +01:00
Code Packages Releases Activity

refactor(TestPodAntiAffinity): create buildTestPod helper to deduplicate 100 and 0 literals

Browse Source
This commit is contained in:
Jan Chaloupka
2025-12-15 12:52:02 +01:00
parent b797ca6ba2
commit 6e753ac5fb
1 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity_test.go
View File

@@ -55,24 +55,28 @@ func buildTestNode1() *v1.Node {
return buildTestNode(nodeName1, setNodeMainRegionLabel) return buildTestNode(nodeName1, setNodeMainRegionLabel)
} }
func buildTestPod(name, nodeName string, apply func(*v1.Pod)) *v1.Pod {
return test.BuildTestPod(name, 100, 0, nodeName, apply)
}
func TestPodAntiAffinity(t *testing.T) { func TestPodAntiAffinity(t *testing.T) {
p1 := test.BuildTestPod("p1", 100, 0, nodeName1, nil) p1 := buildTestPod("p1", nodeName1, nil)
p2 := test.BuildTestPod("p2", 100, 0, nodeName1, nil) p2 := buildTestPod("p2", nodeName1, nil)
p3 := test.BuildTestPod("p3", 100, 0, nodeName1, nil) p3 := buildTestPod("p3", nodeName1, nil)
p4 := test.BuildTestPod("p4", 100, 0, nodeName1, nil) p4 := buildTestPod("p4", nodeName1, nil)
p5 := test.BuildTestPod("p5", 100, 0, nodeName1, nil) p5 := buildTestPod("p5", nodeName1, nil)
p6 := test.BuildTestPod("p6", 100, 0, nodeName1, nil) p6 := buildTestPod("p6", nodeName1, nil)
p7 := test.BuildTestPod("p7", 100, 0, nodeName1, nil) p7 := buildTestPod("p7", nodeName1, nil)
p8 := test.BuildTestPod("p8", 100, 0, nodeName1, nil) p8 := buildTestPod("p8", nodeName1, nil)
p9 := test.BuildTestPod("p9", 100, 0, nodeName1, nil) p9 := buildTestPod("p9", nodeName1, nil)
p10 := test.BuildTestPod("p10", 100, 0, nodeName1, nil) p10 := buildTestPod("p10", nodeName1, nil)
p11 := test.BuildTestPod("p11", 100, 0, nodeName5, nil) p11 := buildTestPod("p11", nodeName5, nil)
p9.DeletionTimestamp = &metav1.Time{} p9.DeletionTimestamp = &metav1.Time{}
p10.DeletionTimestamp = &metav1.Time{} p10.DeletionTimestamp = &metav1.Time{}
criticalPriority := utils.SystemCriticalPriority criticalPriority := utils.SystemCriticalPriority
nonEvictablePod := test.BuildTestPod("non-evict", 100, 0, nodeName1, func(pod *v1.Pod) { nonEvictablePod := buildTestPod("non-evict", nodeName1, func(pod *v1.Pod) {
pod.Spec.Priority = &criticalPriority pod.Spec.Priority = &criticalPriority
}) })
p2.Labels = map[string]string{"foo": "bar"} p2.Labels = map[string]string{"foo": "bar"}