Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-28 06:29:29 +01:00
Code Packages Releases Activity

refactor(TestFindDuplicatePods): inline p13 pod creation

Browse Source
This commit is contained in:
Jan Chaloupka
2025-12-14 14:20:48 +01:00
parent 4e758c18e8
commit 3ebffe5a86
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
pkg/framework/plugins/removeduplicates/removeduplicates_test.go
View File

@@ -99,12 +99,6 @@ func TestFindDuplicatePods(t *testing.T) {
// Three Pods in the "test" Namespace, bound to same ReplicaSet. 2 should be evicted. // Three Pods in the "test" Namespace, bound to same ReplicaSet. 2 should be evicted.
// Same owners, but different images // Same owners, but different images
// Multiple containers // Multiple containers
p13 := buildTestPodWithRSOwnerRefWithNamespaceForNode1("p13", "different-images", func(pod *v1.Pod) {
pod.Spec.Containers = append(pod.Spec.Containers, v1.Container{
Name: "foo",
Image: "foo",
})
})
// ### Pods Evictable Based On Node Fit ### // ### Pods Evictable Based On Node Fit ###
p15 := buildTestPodWithRSOwnerRefWithNamespaceForNode1("p15", "node-fit", func(pod *v1.Pod) { p15 := buildTestPodWithRSOwnerRefWithNamespaceForNode1("p15", "node-fit", func(pod *v1.Pod) {
pod.Spec.NodeSelector = map[string]string{ pod.Spec.NodeSelector = map[string]string{
@@ -273,7 +267,14 @@ func TestFindDuplicatePods(t *testing.T) {
}, },
{ {
description: "Pods with multiple containers should not match themselves", description: "Pods with multiple containers should not match themselves",
pods: []*v1.Pod{p13}, pods: []*v1.Pod{
buildTestPodWithRSOwnerRefWithNamespaceForNode1("p13", "different-images", func(pod *v1.Pod) {
pod.Spec.Containers = append(pod.Spec.Containers, v1.Container{
Name: "foo",
Image: "foo",
})
}),
},
nodes: []*v1.Node{node1, node2}, nodes: []*v1.Node{node1, node2},
expectedEvictedPodCount: 0, expectedEvictedPodCount: 0,
}, },
@@ -282,7 +283,14 @@ func TestFindDuplicatePods(t *testing.T) {
pods: []*v1.Pod{ pods: []*v1.Pod{
buildTestPodWithRSOwnerRefWithNamespaceForNode1("p11", "different-images", func(pod *v1.Pod) { buildTestPodWithRSOwnerRefWithNamespaceForNode1("p11", "different-images", func(pod *v1.Pod) {
pod.Spec.Containers[0].Image = "foo" pod.Spec.Containers[0].Image = "foo"
}), p13}, }),
buildTestPodWithRSOwnerRefWithNamespaceForNode1("p13", "different-images", func(pod *v1.Pod) {
pod.Spec.Containers = append(pod.Spec.Containers, v1.Container{
Name: "foo",
Image: "foo",
})
}),
},
nodes: []*v1.Node{node1, node2}, nodes: []*v1.Node{node1, node2},
expectedEvictedPodCount: 0, expectedEvictedPodCount: 0,
}, },