Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-28 14:41:10 +01:00
Code Packages Releases Activity

lownodeutilization: clarify comments and variable naming for underutilized vs. overutilized

Browse Source
This commit is contained in:
Amir Alavi
2022-06-01 11:39:38 -04:00
parent 8e1d35cb3c
commit 3cc0a68f13
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/descheduler/strategies/nodeutilization/lownodeutilization.go
View File

@@ -104,32 +104,32 @@ func LowNodeUtilization(ctx context.Context, client clientset.Interface, strateg
}, },
) )
// log message in one line // log message for nodes with low utilization
keysAndValues := []interface{}{ underutilizationCriteria := []interface{}{
"CPU", thresholds[v1.ResourceCPU], "CPU", thresholds[v1.ResourceCPU],
"Mem", thresholds[v1.ResourceMemory], "Mem", thresholds[v1.ResourceMemory],
"Pods", thresholds[v1.ResourcePods], "Pods", thresholds[v1.ResourcePods],
} }
for name := range thresholds { for name := range thresholds {
if !nodeutil.IsBasicResource(name) { if !nodeutil.IsBasicResource(name) {
keysAndValues = append(keysAndValues, string(name), int64(thresholds[name])) underutilizationCriteria = append(underutilizationCriteria, string(name), int64(thresholds[name]))
} }
} }
klog.V(1).InfoS("Criteria for a node under utilization", keysAndValues...) klog.V(1).InfoS("Criteria for a node under utilization", underutilizationCriteria...)
klog.V(1).InfoS("Number of underutilized nodes", "totalNumber", len(lowNodes)) klog.V(1).InfoS("Number of underutilized nodes", "totalNumber", len(lowNodes))
// log message in one line // log message for over utilized nodes
keysAndValues = []interface{}{ overutilizationCriteria := []interface{}{
"CPU", targetThresholds[v1.ResourceCPU], "CPU", targetThresholds[v1.ResourceCPU],
"Mem", targetThresholds[v1.ResourceMemory], "Mem", targetThresholds[v1.ResourceMemory],
"Pods", targetThresholds[v1.ResourcePods], "Pods", targetThresholds[v1.ResourcePods],
} }
for name := range targetThresholds { for name := range targetThresholds {
if !nodeutil.IsBasicResource(name) { if !nodeutil.IsBasicResource(name) {
keysAndValues = append(keysAndValues, string(name), int64(targetThresholds[name])) overutilizationCriteria = append(overutilizationCriteria, string(name), int64(targetThresholds[name]))
} }
} }
klog.V(1).InfoS("Criteria for a node above target utilization", keysAndValues...) klog.V(1).InfoS("Criteria for a node above target utilization", overutilizationCriteria...)
klog.V(1).InfoS("Number of overutilized nodes", "totalNumber", len(sourceNodes)) klog.V(1).InfoS("Number of overutilized nodes", "totalNumber", len(sourceNodes))
if len(lowNodes) == 0 { if len(lowNodes) == 0 {