add v1alpha2 registry based conversion (#1006)

* add v1alpha2 registry based conversion

* test defaults, set our 1st explicit default

* fix typos and dates

* move pluginregistry to its own dir

* remove unused v1alpha2.Namespace type

* move migration code folders, remove switch

* validate internalPolicy a single time

* remove structured logs

* simplify return

* check for nil methods

* properly check before adding default evictor

* add TODO comment

* bump copyright year

pkg/api/v1alpha1/conversion.go

@@ -0,0 +1,244 @@
+/*
+Copyright 2023 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1alpha1
+
+import (
+	"context"
+	"fmt"
+
+	v1 "k8s.io/api/core/v1"
+	"k8s.io/client-go/informers"
+	clientset "k8s.io/client-go/kubernetes"
+	"k8s.io/klog/v2"
+	"sigs.k8s.io/descheduler/pkg/api"
+	"sigs.k8s.io/descheduler/pkg/descheduler/evictions"
+	podutil "sigs.k8s.io/descheduler/pkg/descheduler/pod"
+	"sigs.k8s.io/descheduler/pkg/framework"
+	"sigs.k8s.io/descheduler/pkg/framework/pluginregistry"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor"
+	"sigs.k8s.io/descheduler/pkg/utils"
+)
+
+// evictorImpl implements the Evictor interface so plugins
+// can evict a pod without importing a specific pod evictor
+type evictorImpl struct {
+	podEvictor    *evictions.PodEvictor
+	evictorFilter framework.EvictorPlugin
+}
+
+var _ framework.Evictor = &evictorImpl{}
+
+// Filter checks if a pod can be evicted
+func (ei *evictorImpl) Filter(pod *v1.Pod) bool {
+	return ei.evictorFilter.Filter(pod)
+}
+
+// PreEvictionFilter checks if pod can be evicted right before eviction
+func (ei *evictorImpl) PreEvictionFilter(pod *v1.Pod) bool {
+	return ei.evictorFilter.PreEvictionFilter(pod)
+}
+
+// Evict evicts a pod (no pre-check performed)
+func (ei *evictorImpl) Evict(ctx context.Context, pod *v1.Pod, opts evictions.EvictOptions) bool {
+	return ei.podEvictor.EvictPod(ctx, pod, opts)
+}
+
+func (ei *evictorImpl) NodeLimitExceeded(node *v1.Node) bool {
+	return ei.podEvictor.NodeLimitExceeded(node)
+}
+
+// handleImpl implements the framework handle which gets passed to plugins
+type handleImpl struct {
+	clientSet                 clientset.Interface
+	getPodsAssignedToNodeFunc podutil.GetPodsAssignedToNodeFunc
+	sharedInformerFactory     informers.SharedInformerFactory
+	evictor                   *evictorImpl
+}
+
+var _ framework.Handle = &handleImpl{}
+
+// ClientSet retrieves kube client set
+func (hi *handleImpl) ClientSet() clientset.Interface {
+	return hi.clientSet
+}
+
+// GetPodsAssignedToNodeFunc retrieves GetPodsAssignedToNodeFunc implementation
+func (hi *handleImpl) GetPodsAssignedToNodeFunc() podutil.GetPodsAssignedToNodeFunc {
+	return hi.getPodsAssignedToNodeFunc
+}
+
+// SharedInformerFactory retrieves shared informer factory
+func (hi *handleImpl) SharedInformerFactory() informers.SharedInformerFactory {
+	return hi.sharedInformerFactory
+}
+
+// Evictor retrieves evictor so plugins can filter and evict pods
+func (hi *handleImpl) Evictor() framework.Evictor {
+	return hi.evictor
+}
+
+func V1alpha1ToInternal(
+	client clientset.Interface,
+	deschedulerPolicy *DeschedulerPolicy,
+	registry pluginregistry.Registry,
+) (*api.DeschedulerPolicy, error) {
+	var evictLocalStoragePods bool
+	if deschedulerPolicy.EvictLocalStoragePods != nil {
+		evictLocalStoragePods = *deschedulerPolicy.EvictLocalStoragePods
+	}
+
+	evictBarePods := false
+	if deschedulerPolicy.EvictFailedBarePods != nil {
+		evictBarePods = *deschedulerPolicy.EvictFailedBarePods
+		if evictBarePods {
+			klog.V(1).Info("Warning: EvictFailedBarePods is set to True. This could cause eviction of pods without ownerReferences.")
+		}
+	}
+
+	evictSystemCriticalPods := false
+	if deschedulerPolicy.EvictSystemCriticalPods != nil {
+		evictSystemCriticalPods = *deschedulerPolicy.EvictSystemCriticalPods
+		if evictSystemCriticalPods {
+			klog.V(1).Info("Warning: EvictSystemCriticalPods is set to True. This could cause eviction of Kubernetes system pods.")
+		}
+	}
+
+	ignorePvcPods := false
+	if deschedulerPolicy.IgnorePVCPods != nil {
+		ignorePvcPods = *deschedulerPolicy.IgnorePVCPods
+	}
+
+	var profiles []api.Profile
+
+	// Build profiles
+	for name, strategy := range deschedulerPolicy.Strategies {
+		if _, ok := pluginregistry.PluginRegistry[string(name)]; ok {
+			if strategy.Enabled {
+				params := strategy.Params
+				if params == nil {
+					params = &StrategyParameters{}
+				}
+
+				nodeFit := false
+				if name != "PodLifeTime" {
+					nodeFit = params.NodeFit
+				}
+
+				if params.ThresholdPriority != nil && params.ThresholdPriorityClassName != "" {
+					klog.ErrorS(fmt.Errorf("priority threshold misconfigured"), "only one of priorityThreshold fields can be set", "pluginName", name)
+					return nil, fmt.Errorf("priority threshold misconfigured for plugin %v", name)
+				}
+
+				var priorityThreshold *api.PriorityThreshold
+				if strategy.Params != nil {
+					priorityThreshold = &api.PriorityThreshold{
+						Value: strategy.Params.ThresholdPriority,
+						Name:  strategy.Params.ThresholdPriorityClassName,
+					}
+				}
+				thresholdPriority, err := utils.GetPriorityFromStrategyParams(context.TODO(), client, priorityThreshold)
+				if err != nil {
+					klog.ErrorS(err, "Failed to get threshold priority from strategy's params")
+					return nil, fmt.Errorf("failed to get threshold priority from strategy's params: %v", err)
+				}
+
+				var pluginConfig *api.PluginConfig
+				if pcFnc, exists := StrategyParamsToPluginArgs[string(name)]; exists {
+					pluginConfig, err = pcFnc(params)
+					if err != nil {
+						klog.ErrorS(err, "skipping strategy", "strategy", name)
+						return nil, fmt.Errorf("failed to get plugin config for strategy %v: %v", name, err)
+					}
+				} else {
+					klog.ErrorS(fmt.Errorf("unknown strategy name"), "skipping strategy", "strategy", name)
+					return nil, fmt.Errorf("unknown strategy name: %v", name)
+				}
+
+				profile := api.Profile{
+					Name: fmt.Sprintf("strategy-%v-profile", name),
+					PluginConfigs: []api.PluginConfig{
+						{
+							Name: defaultevictor.PluginName,
+							Args: &defaultevictor.DefaultEvictorArgs{
+								EvictLocalStoragePods:   evictLocalStoragePods,
+								EvictSystemCriticalPods: evictSystemCriticalPods,
+								IgnorePvcPods:           ignorePvcPods,
+								EvictFailedBarePods:     evictBarePods,
+								NodeFit:                 nodeFit,
+								PriorityThreshold: &api.PriorityThreshold{
+									Value: &thresholdPriority,
+								},
+							},
+						},
+						*pluginConfig,
+					},
+					Plugins: api.Plugins{
+						Evict: api.PluginSet{
+							Enabled: []string{defaultevictor.PluginName},
+						},
+					},
+				}
+
+				pluginArgs := registry[string(name)].PluginArgInstance
+				pluginInstance, err := registry[string(name)].PluginBuilder(pluginArgs, &handleImpl{})
+				if err != nil {
+					klog.ErrorS(fmt.Errorf("could not build plugin"), "plugin build error", "plugin", name)
+					return nil, fmt.Errorf("could not build plugin: %v", name)
+				}
+
+				// pluginInstance can be of any of each type, or both
+				profilePlugins := profile.Plugins
+				profile.Plugins = enableProfilePluginsByType(profilePlugins, pluginInstance, pluginConfig)
+				profiles = append(profiles, profile)
+			}
+		} else {
+			klog.ErrorS(fmt.Errorf("unknown strategy name"), "skipping strategy", "strategy", name)
+			return nil, fmt.Errorf("unknown strategy name: %v", name)
+		}
+	}
+
+	return &api.DeschedulerPolicy{
+		Profiles:                       profiles,
+		NodeSelector:                   deschedulerPolicy.NodeSelector,
+		MaxNoOfPodsToEvictPerNode:      deschedulerPolicy.MaxNoOfPodsToEvictPerNode,
+		MaxNoOfPodsToEvictPerNamespace: deschedulerPolicy.MaxNoOfPodsToEvictPerNamespace,
+	}, nil
+}
+
+func enableProfilePluginsByType(profilePlugins api.Plugins, pluginInstance framework.Plugin, pluginConfig *api.PluginConfig) api.Plugins {
+	profilePlugins = checkBalance(profilePlugins, pluginInstance, pluginConfig)
+	profilePlugins = checkDeschedule(profilePlugins, pluginInstance, pluginConfig)
+	return profilePlugins
+}
+
+func checkBalance(profilePlugins api.Plugins, pluginInstance framework.Plugin, pluginConfig *api.PluginConfig) api.Plugins {
+	_, ok := pluginInstance.(framework.BalancePlugin)
+	if ok {
+		klog.V(3).Info("converting Balance plugin: %s", pluginInstance.Name())
+		profilePlugins.Balance.Enabled = []string{pluginConfig.Name}
+	}
+	return profilePlugins
+}
+
+func checkDeschedule(profilePlugins api.Plugins, pluginInstance framework.Plugin, pluginConfig *api.PluginConfig) api.Plugins {
+	_, ok := pluginInstance.(framework.DeschedulePlugin)
+	if ok {
+		klog.V(3).Info("converting Deschedule plugin: %s", pluginInstance.Name())
+		profilePlugins.Deschedule.Enabled = []string{pluginConfig.Name}
+	}
+	return profilePlugins
+}

pkg/api/v1alpha1/strategymigration.go

@@ -0,0 +1,249 @@
+/*
+Copyright 2023 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1alpha1
+
+import (
+	"fmt"
+
+	"k8s.io/klog/v2"
+	"sigs.k8s.io/descheduler/pkg/api"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/nodeutilization"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/podlifetime"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removeduplicates"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removefailedpods"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatinginterpodantiaffinity"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingnodeaffinity"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingnodetaints"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingtopologyspreadconstraint"
+)
+
+// Once all strategies are migrated the arguments get read from the configuration file
+// without any wiring. Keeping the wiring here so the descheduler can still use
+// the v1alpha1 configuration during the strategy migration to plugins.
+
+var StrategyParamsToPluginArgs = map[string]func(params *StrategyParameters) (*api.PluginConfig, error){
+	"RemovePodsViolatingNodeTaints": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		args := &removepodsviolatingnodetaints.RemovePodsViolatingNodeTaintsArgs{
+			Namespaces:              v1alpha1NamespacesToInternal(params.Namespaces),
+			LabelSelector:           params.LabelSelector,
+			IncludePreferNoSchedule: params.IncludePreferNoSchedule,
+			ExcludedTaints:          params.ExcludedTaints,
+		}
+		if err := removepodsviolatingnodetaints.ValidateRemovePodsViolatingNodeTaintsArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", removepodsviolatingnodetaints.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", removepodsviolatingnodetaints.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: removepodsviolatingnodetaints.PluginName,
+			Args: args,
+		}, nil
+	},
+	"RemoveFailedPods": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		failedPodsParams := params.FailedPods
+		if failedPodsParams == nil {
+			failedPodsParams = &FailedPods{}
+		}
+		args := &removefailedpods.RemoveFailedPodsArgs{
+			Namespaces:              v1alpha1NamespacesToInternal(params.Namespaces),
+			LabelSelector:           params.LabelSelector,
+			IncludingInitContainers: failedPodsParams.IncludingInitContainers,
+			MinPodLifetimeSeconds:   failedPodsParams.MinPodLifetimeSeconds,
+			ExcludeOwnerKinds:       failedPodsParams.ExcludeOwnerKinds,
+			Reasons:                 failedPodsParams.Reasons,
+		}
+		if err := removefailedpods.ValidateRemoveFailedPodsArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", removefailedpods.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", removefailedpods.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: removefailedpods.PluginName,
+			Args: args,
+		}, nil
+	},
+	"RemovePodsViolatingNodeAffinity": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		args := &removepodsviolatingnodeaffinity.RemovePodsViolatingNodeAffinityArgs{
+			Namespaces:       v1alpha1NamespacesToInternal(params.Namespaces),
+			LabelSelector:    params.LabelSelector,
+			NodeAffinityType: params.NodeAffinityType,
+		}
+		if err := removepodsviolatingnodeaffinity.ValidateRemovePodsViolatingNodeAffinityArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", removepodsviolatingnodeaffinity.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", removepodsviolatingnodeaffinity.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: removepodsviolatingnodeaffinity.PluginName,
+			Args: args,
+		}, nil
+	},
+	"RemovePodsViolatingInterPodAntiAffinity": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		args := &removepodsviolatinginterpodantiaffinity.RemovePodsViolatingInterPodAntiAffinityArgs{
+			Namespaces:    v1alpha1NamespacesToInternal(params.Namespaces),
+			LabelSelector: params.LabelSelector,
+		}
+		if err := removepodsviolatinginterpodantiaffinity.ValidateRemovePodsViolatingInterPodAntiAffinityArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", removepodsviolatinginterpodantiaffinity.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", removepodsviolatinginterpodantiaffinity.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: removepodsviolatinginterpodantiaffinity.PluginName,
+			Args: args,
+		}, nil
+	},
+	"RemovePodsHavingTooManyRestarts": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		tooManyRestartsParams := params.PodsHavingTooManyRestarts
+		if tooManyRestartsParams == nil {
+			tooManyRestartsParams = &PodsHavingTooManyRestarts{}
+		}
+		args := &removepodshavingtoomanyrestarts.RemovePodsHavingTooManyRestartsArgs{
+			Namespaces:              v1alpha1NamespacesToInternal(params.Namespaces),
+			LabelSelector:           params.LabelSelector,
+			PodRestartThreshold:     tooManyRestartsParams.PodRestartThreshold,
+			IncludingInitContainers: tooManyRestartsParams.IncludingInitContainers,
+		}
+		if err := removepodshavingtoomanyrestarts.ValidateRemovePodsHavingTooManyRestartsArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", removepodshavingtoomanyrestarts.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", removepodshavingtoomanyrestarts.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: removepodshavingtoomanyrestarts.PluginName,
+			Args: args,
+		}, nil
+	},
+	"PodLifeTime": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		podLifeTimeParams := params.PodLifeTime
+		if podLifeTimeParams == nil {
+			podLifeTimeParams = &PodLifeTime{}
+		}
+
+		var states []string
+		if podLifeTimeParams.PodStatusPhases != nil {
+			states = append(states, podLifeTimeParams.PodStatusPhases...)
+		}
+		if podLifeTimeParams.States != nil {
+			states = append(states, podLifeTimeParams.States...)
+		}
+
+		args := &podlifetime.PodLifeTimeArgs{
+			Namespaces:            v1alpha1NamespacesToInternal(params.Namespaces),
+			LabelSelector:         params.LabelSelector,
+			MaxPodLifeTimeSeconds: podLifeTimeParams.MaxPodLifeTimeSeconds,
+			States:                states,
+		}
+		if err := podlifetime.ValidatePodLifeTimeArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", podlifetime.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", podlifetime.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: podlifetime.PluginName,
+			Args: args,
+		}, nil
+	},
+	"RemoveDuplicates": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		args := &removeduplicates.RemoveDuplicatesArgs{
+			Namespaces: v1alpha1NamespacesToInternal(params.Namespaces),
+		}
+		if params.RemoveDuplicates != nil {
+			args.ExcludeOwnerKinds = params.RemoveDuplicates.ExcludeOwnerKinds
+		}
+		if err := removeduplicates.ValidateRemoveDuplicatesArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", removeduplicates.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", removeduplicates.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: removeduplicates.PluginName,
+			Args: args,
+		}, nil
+	},
+	"RemovePodsViolatingTopologySpreadConstraint": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		args := &removepodsviolatingtopologyspreadconstraint.RemovePodsViolatingTopologySpreadConstraintArgs{
+			Namespaces:             v1alpha1NamespacesToInternal(params.Namespaces),
+			LabelSelector:          params.LabelSelector,
+			IncludeSoftConstraints: params.IncludeSoftConstraints,
+		}
+		if err := removepodsviolatingtopologyspreadconstraint.ValidateRemovePodsViolatingTopologySpreadConstraintArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", removepodsviolatingtopologyspreadconstraint.PluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", removepodsviolatingtopologyspreadconstraint.PluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: removepodsviolatingtopologyspreadconstraint.PluginName,
+			Args: args,
+		}, nil
+	},
+	"HighNodeUtilization": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		if params.NodeResourceUtilizationThresholds == nil {
+			params.NodeResourceUtilizationThresholds = &NodeResourceUtilizationThresholds{}
+		}
+		args := &nodeutilization.HighNodeUtilizationArgs{
+			EvictableNamespaces: v1alpha1NamespacesToInternal(params.Namespaces),
+			Thresholds:          v1alpha1ThresholdToInternal(params.NodeResourceUtilizationThresholds.Thresholds),
+			NumberOfNodes:       params.NodeResourceUtilizationThresholds.NumberOfNodes,
+		}
+		if err := nodeutilization.ValidateHighNodeUtilizationArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", nodeutilization.HighNodeUtilizationPluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", nodeutilization.HighNodeUtilizationPluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: nodeutilization.HighNodeUtilizationPluginName,
+			Args: args,
+		}, nil
+	},
+	"LowNodeUtilization": func(params *StrategyParameters) (*api.PluginConfig, error) {
+		if params.NodeResourceUtilizationThresholds == nil {
+			params.NodeResourceUtilizationThresholds = &NodeResourceUtilizationThresholds{}
+		}
+		args := &nodeutilization.LowNodeUtilizationArgs{
+			EvictableNamespaces:    v1alpha1NamespacesToInternal(params.Namespaces),
+			Thresholds:             v1alpha1ThresholdToInternal(params.NodeResourceUtilizationThresholds.Thresholds),
+			TargetThresholds:       v1alpha1ThresholdToInternal(params.NodeResourceUtilizationThresholds.TargetThresholds),
+			UseDeviationThresholds: params.NodeResourceUtilizationThresholds.UseDeviationThresholds,
+			NumberOfNodes:          params.NodeResourceUtilizationThresholds.NumberOfNodes,
+		}
+
+		if err := nodeutilization.ValidateLowNodeUtilizationArgs(args); err != nil {
+			klog.ErrorS(err, "unable to validate plugin arguments", "pluginName", nodeutilization.LowNodeUtilizationPluginName)
+			return nil, fmt.Errorf("strategy %q param validation failed: %v", nodeutilization.LowNodeUtilizationPluginName, err)
+		}
+		return &api.PluginConfig{
+			Name: nodeutilization.LowNodeUtilizationPluginName,
+			Args: args,
+		}, nil
+	},
+}
+
+func v1alpha1NamespacesToInternal(namespaces *Namespaces) *api.Namespaces {
+	internal := &api.Namespaces{}
+	if namespaces != nil {
+		if namespaces.Exclude != nil {
+			internal.Exclude = namespaces.Exclude
+		}
+		if namespaces.Include != nil {
+			internal.Include = namespaces.Include
+		}
+	} else {
+		internal = nil
+	}
+	return internal
+}
+
+func v1alpha1ThresholdToInternal(thresholds ResourceThresholds) api.ResourceThresholds {
+	internal := make(api.ResourceThresholds, len(thresholds))
+	for k, v := range thresholds {
+		internal[k] = api.Percentage(float64(v))
+	}
+	return internal
+}

pkg/api/v1alpha1/strategymigration_test.go

@@ -0,0 +1,843 @@
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1alpha1
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+	utilpointer "k8s.io/utils/pointer"
+	"sigs.k8s.io/descheduler/pkg/api"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/nodeutilization"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/podlifetime"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removeduplicates"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removefailedpods"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatinginterpodantiaffinity"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingnodeaffinity"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingnodetaints"
+	"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingtopologyspreadconstraint"
+)
+
+func TestStrategyParamsToPluginArgsRemovePodsViolatingNodeTaints(t *testing.T) {
+	strategyName := "RemovePodsViolatingNodeTaints"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				ExcludedTaints: []string{
+					"dedicated=special-user",
+					"reserved",
+				},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: removepodsviolatingnodetaints.PluginName,
+				Args: &removepodsviolatingnodetaints.RemovePodsViolatingNodeTaintsArgs{
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+					ExcludedTaints: []string{"dedicated=special-user", "reserved"},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsRemoveFailedPods(t *testing.T) {
+	strategyName := "RemoveFailedPods"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				FailedPods: &FailedPods{
+					MinPodLifetimeSeconds:   utilpointer.Uint(3600),
+					ExcludeOwnerKinds:       []string{"Job"},
+					Reasons:                 []string{"NodeAffinity"},
+					IncludingInitContainers: true,
+				},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: removefailedpods.PluginName,
+				Args: &removefailedpods.RemoveFailedPodsArgs{
+					ExcludeOwnerKinds:       []string{"Job"},
+					MinPodLifetimeSeconds:   utilpointer.Uint(3600),
+					Reasons:                 []string{"NodeAffinity"},
+					IncludingInitContainers: true,
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsRemovePodsViolatingNodeAffinity(t *testing.T) {
+	strategyName := "RemovePodsViolatingNodeAffinity"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				NodeAffinityType:  []string{"requiredDuringSchedulingIgnoredDuringExecution"},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: removepodsviolatingnodeaffinity.PluginName,
+				Args: &removepodsviolatingnodeaffinity.RemovePodsViolatingNodeAffinityArgs{
+					NodeAffinityType: []string{"requiredDuringSchedulingIgnoredDuringExecution"},
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params, not setting nodeaffinity type",
+			params:      &StrategyParameters{},
+			err:         fmt.Errorf("strategy \"%s\" param validation failed: nodeAffinityType needs to be set", strategyName),
+			result:      nil,
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				NodeAffinityType: []string{"requiredDuringSchedulingIgnoredDuringExecution"},
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsRemovePodsViolatingInterPodAntiAffinity(t *testing.T) {
+	strategyName := "RemovePodsViolatingInterPodAntiAffinity"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: removepodsviolatinginterpodantiaffinity.PluginName,
+				Args: &removepodsviolatinginterpodantiaffinity.RemovePodsViolatingInterPodAntiAffinityArgs{
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsRemovePodsHavingTooManyRestarts(t *testing.T) {
+	strategyName := "RemovePodsHavingTooManyRestarts"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				PodsHavingTooManyRestarts: &PodsHavingTooManyRestarts{
+					PodRestartThreshold:     100,
+					IncludingInitContainers: true,
+				},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: removepodshavingtoomanyrestarts.PluginName,
+				Args: &removepodshavingtoomanyrestarts.RemovePodsHavingTooManyRestartsArgs{
+					PodRestartThreshold:     100,
+					IncludingInitContainers: true,
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+		{
+			description: "invalid params restart threshold",
+			params: &StrategyParameters{
+				PodsHavingTooManyRestarts: &PodsHavingTooManyRestarts{
+					PodRestartThreshold: 0,
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: invalid PodsHavingTooManyRestarts threshold", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsPodLifeTime(t *testing.T) {
+	strategyName := "PodLifeTime"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				PodLifeTime: &PodLifeTime{
+					MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
+					States: []string{
+						"Pending",
+						"PodInitializing",
+					},
+				},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: podlifetime.PluginName,
+				Args: &podlifetime.PodLifeTimeArgs{
+					MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
+					States: []string{
+						"Pending",
+						"PodInitializing",
+					},
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				PodLifeTime: &PodLifeTime{
+					MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
+				},
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+		{
+			description: "invalid params MaxPodLifeTimeSeconds not set",
+			params: &StrategyParameters{
+				PodLifeTime: &PodLifeTime{},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: MaxPodLifeTimeSeconds not set", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsRemoveDuplicates(t *testing.T) {
+	strategyName := "RemoveDuplicates"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				RemoveDuplicates: &RemoveDuplicates{
+					ExcludeOwnerKinds: []string{"ReplicaSet"},
+				},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: removeduplicates.PluginName,
+				Args: &removeduplicates.RemoveDuplicatesArgs{
+					ExcludeOwnerKinds: []string{"ReplicaSet"},
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				PodLifeTime: &PodLifeTime{
+					MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
+				},
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsRemovePodsViolatingTopologySpreadConstraint(t *testing.T) {
+	strategyName := "RemovePodsViolatingTopologySpreadConstraint"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				IncludeSoftConstraints: true,
+				ThresholdPriority:      utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: removepodsviolatingtopologyspreadconstraint.PluginName,
+				Args: &removepodsviolatingtopologyspreadconstraint.RemovePodsViolatingTopologySpreadConstraintArgs{
+					IncludeSoftConstraints: true,
+					Namespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsHighNodeUtilization(t *testing.T) {
+	strategyName := "HighNodeUtilization"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+					Thresholds: ResourceThresholds{
+						"cpu":    Percentage(20),
+						"memory": Percentage(20),
+						"pods":   Percentage(20),
+					},
+				},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: nodeutilization.HighNodeUtilizationPluginName,
+				Args: &nodeutilization.HighNodeUtilizationArgs{
+					Thresholds: api.ResourceThresholds{
+						"cpu":    api.Percentage(20),
+						"memory": api.Percentage(20),
+						"pods":   api.Percentage(20),
+					},
+					NumberOfNodes: 3,
+					EvictableNamespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+					Thresholds: ResourceThresholds{
+						"cpu":    Percentage(20),
+						"memory": Percentage(20),
+						"pods":   Percentage(20),
+					},
+				},
+				Namespaces: &Namespaces{
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only Exclude namespaces can be set, inclusion is not supported", strategyName),
+			result: nil,
+		},
+		{
+			description: "invalid params nil ResourceThresholds",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: no resource threshold is configured", strategyName),
+			result: nil,
+		},
+		{
+			description: "invalid params out of bounds threshold",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+					Thresholds: ResourceThresholds{
+						"cpu": Percentage(150),
+					},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: cpu threshold not in [0, 100] range", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}
+
+func TestStrategyParamsToPluginArgsLowNodeUtilization(t *testing.T) {
+	strategyName := "LowNodeUtilization"
+	type testCase struct {
+		description string
+		params      *StrategyParameters
+		err         error
+		result      *api.PluginConfig
+	}
+	testCases := []testCase{
+		{
+			description: "wire in all valid parameters",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+					Thresholds: ResourceThresholds{
+						"cpu":    Percentage(20),
+						"memory": Percentage(20),
+						"pods":   Percentage(20),
+					},
+					TargetThresholds: ResourceThresholds{
+						"cpu":    Percentage(50),
+						"memory": Percentage(50),
+						"pods":   Percentage(50),
+					},
+					UseDeviationThresholds: true,
+				},
+				ThresholdPriority: utilpointer.Int32(100),
+				Namespaces: &Namespaces{
+					Exclude: []string{"test1"},
+				},
+			},
+			err: nil,
+			result: &api.PluginConfig{
+				Name: nodeutilization.LowNodeUtilizationPluginName,
+				Args: &nodeutilization.LowNodeUtilizationArgs{
+					Thresholds: api.ResourceThresholds{
+						"cpu":    api.Percentage(20),
+						"memory": api.Percentage(20),
+						"pods":   api.Percentage(20),
+					},
+					TargetThresholds: api.ResourceThresholds{
+						"cpu":    api.Percentage(50),
+						"memory": api.Percentage(50),
+						"pods":   api.Percentage(50),
+					},
+					UseDeviationThresholds: true,
+					NumberOfNodes:          3,
+					EvictableNamespaces: &api.Namespaces{
+						Exclude: []string{"test1"},
+					},
+				},
+			},
+		},
+		{
+			description: "invalid params namespaces",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+					Thresholds: ResourceThresholds{
+						"cpu":    Percentage(20),
+						"memory": Percentage(20),
+						"pods":   Percentage(20),
+					},
+					TargetThresholds: ResourceThresholds{
+						"cpu":    Percentage(50),
+						"memory": Percentage(50),
+						"pods":   Percentage(50),
+					},
+					UseDeviationThresholds: true,
+				},
+				Namespaces: &Namespaces{
+					Include: []string{"test2"},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: only Exclude namespaces can be set, inclusion is not supported", strategyName),
+			result: nil,
+		},
+		{
+			description: "invalid params nil ResourceThresholds",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: thresholds config is not valid: no resource threshold is configured", strategyName),
+			result: nil,
+		},
+		{
+			description: "invalid params out of bounds threshold",
+			params: &StrategyParameters{
+				NodeResourceUtilizationThresholds: &NodeResourceUtilizationThresholds{
+					NumberOfNodes: 3,
+					Thresholds: ResourceThresholds{
+						"cpu": Percentage(150),
+					},
+				},
+			},
+			err:    fmt.Errorf("strategy \"%s\" param validation failed: thresholds config is not valid: cpu threshold not in [0, 100] range", strategyName),
+			result: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			var result *api.PluginConfig
+			var err error
+			if pcFnc, exists := StrategyParamsToPluginArgs[strategyName]; exists {
+				result, err = pcFnc(tc.params)
+			}
+			if err != nil {
+				if err.Error() != tc.err.Error() {
+					t.Errorf("unexpected error: %s", err.Error())
+				}
+			}
+			if err == nil {
+				// sort to easily compare deepequality
+				diff := cmp.Diff(tc.result, result)
+				if diff != "" {
+					t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
+				}
+			}
+		})
+	}
+}